Protocol, error handling, other improvements#230
Merged
Conversation
Declare a constant value of 5 seconds for communications with the NUT server (temporary patch until we have true async communication)
- Added a general description to the header of the Nut_Socket class - Removed redundant check during query for server version (NutException or others thrown in adverse conditions) - Entire response of VER query is accepted, rather than trying to locate the semver string specifically
Common_Enums: - Removed "EMPTY" NUTResponse; `EndOfStreamException` thrown instead. Common_Classes: - Adding String array to Transaction class to store split responses so split operation doesn't need to be repeated for later processing. - Remove extra NutError constructor Nut_Socket: - Remove redundant check in NETVER query since errors are thrown - Slightly adjust order of operations in Connect subroutine - Adding `OnSocketBroken` subroutine to handle errors during Query_Data - Catch exceptions when reading and writing to the socket so the object can reset its state and disconnect - Remove unnecessary operations on response string - Opportunistically throw exceptions when necessary during response parsing UPS_Device: - Start Update_Data timer later on in connection sequence, and retrieve a copy of the data right away. - Enhanced parameter checking in GetUPSVar - Simplified response verification - Combined exception handling and record the last exception - For Loop is only continued under specific circumstances now - Better error logging towards end of GetUPSVar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes
Outline
Common_Enums:
EndOfStreamExceptionthrown instead.Common_Classes:
NutErrorconstructorNut_Socket:
OnSocketBrokensubroutine to handle errors during Query_DataUPS_Device:
Closes #223